Repository navigation
Use AddressForm at additional details page - #10234
Conversation
|
At additional page we were showing city, state and zip code field only after user types something at Personal address field. Now because we are using |
|
Screen.Recording.2022-08-04.at.12.34.56.AM.mov |
|
@thesahindia reported a bug - inputs are getting cleared automatically. @thesahindia would you like to solve this bug in this PR itself? Because I don't like the fact that we'll be shipping a unusable page. (ofc the bounty will be increased + reporting bonus) |
|
Please merge |
…e-AddressForm merge main
Hmm I tried but only found the solution for this one |
that's alright |
|
@thesahindia is the search functionality working for you? Screen.Recording.2022-08-10.at.12.25.15.AM.mov |
|
Yeah it's working, you have to check this at desktop. You won't be able to test this on local web Screen.Recording.2022-08-10.at.12.41.08.AM.mov |
|
Okayy, thanks for the info! I just confirmed it again. |
rushatgabhane
left a comment
There was a problem hiding this comment.
@MonilBhavsar LGTM! 🎉
PR Reviewer Checklist
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
- I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all
src/languages/*files - I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - Any functional components have the
displayNameproperty - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
- If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
|
Could anyone please clarify testing steps. I'm not able to get additional details page during bank account setup. May be I'm missing something? |
I tested it by rendering this EnablePaymentsPage at a different route. But there are two ways to reach this page ( I found them on some other issues ) 1st way (not really sure about this but you have to in some beta for this) -
2nd -
|
|
Found the QA steps (don't know if this works locally on web, probably it will work for desktop app)
or just visit https://new.expensify.com/enable-payments |
|
@MonilBhavsar bump :) |
|
Oops sorry, missed this. Looking now 👁️ |
|
@thesahindia since it's been a while. Could you please merge main in this branch. Thank you! 🙏 |
|
I am out right now, away from my mac. It will take me a few hours (2 maybe) |
Done :) |
|
In some accounts where bank account is already setup, additional information form is only accessed by going to |
Done, Added. |
|
Thanks! |
|
@MonilBhavsar looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
|
PR Reviewer and contributor checklist are completed. Looks like we're still working to fix the integration. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @MonilBhavsar in version: 1.2.2-0 🚀
|
|
🚀 Deployed to production by @luacmartins in version: 1.2.2-0 🚀
|
Details
At additional details page we didn't have state picker and there wasn't any character limit or validation for zip code, this PR fixes that.
Fixed Issues
$ #9702
Tests
Note: In some accounts where bank account is already setup, additional information form is only accessed by going to enable-payments in url(e.g. https://staging.new.expensify.com/enable-payments)
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*filesSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */displayNamepropertythisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick).src/languages/*filesSTYLE.md) were followedAvatar, I verified the components usingAvatarhave been tested & I retested again)/** comment above it */displayNamepropertythisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)QA Steps
Note: In some accounts where bank account is already setup, additional information form is only accessed by going to enable-payments in url(e.g. https://staging.new.expensify.com/enable-payments)
Screenshots
Web
Mobile Web
Desktop
iOS
Android