Skip to content

Use AddressForm at additional details page - #10234

Merged
MonilBhavsar merged 7 commits into
Expensify:mainfrom
thesahindia:thesahindia/use-AddressForm
Sep 19, 2022
Merged

MonilBhavsar merged 7 commits into
Expensify:mainfrom
thesahindia:thesahindia/use-AddressForm

Conversation

@thesahindia

@thesahindia thesahindia commented Aug 3, 2022 •

Copy link
Copy Markdown
Member

Details

At additional details page we didn't have state picker and there wasn't any character limit or validation for zip code, this PR fixes that.

Fixed Issues

$ #9702

Tests

  1. Click on Fab icon > send money > onfido verification > Additional details page
  2. Verify there's a state picker
  3. Verify there's a character limit on zip code field
  4. Verify you get error on using invalid zip code (try alphabets)

Note: In some accounts where bank account is already setup, additional information form is only accessed by going to enable-payments in url(e.g. https://staging.new.expensify.com/enable-payments)

  • Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • Any functional components have the displayName property
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • Any functional components have the displayName property
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

  1. Click on Fab icon > send money > onfido verification > Additional details page
  2. Verify there's a state picker
  3. Verify there's a character limit on zip code field
  4. Verify you get error on using invalid zip code (try alphabets)

Note: In some accounts where bank account is already setup, additional information form is only accessed by going to enable-payments in url(e.g. https://staging.new.expensify.com/enable-payments)

  • Verify that no errors appear in the JS console

Screenshots

Web

Screenshot 2022-08-03 at 11 07 44 PM

Mobile Web

Screenshot 2022-08-03 at 11 17 16 PM

Desktop

Screenshot 2022-08-03 at 11 23 50 PM

iOS

Screenshot 2022-08-03 at 11 15 19 PM

Android

Screenshot 2022-08-03 at 11 21 02 PM

@thesahindia
thesahindia marked this pull request as ready for review August 3, 2022 18:50
@thesahindia
thesahindia requested a review from a team as a code owner August 3, 2022 18:50
@melvin-bot
melvin-bot Bot requested review from MonilBhavsar and rushatgabhane and removed request for a team August 3, 2022 18:50
@thesahindia

Copy link
Copy Markdown
Member Author

At additional page we were showing city, state and zip code field only after user types something at Personal address field. Now because we are using AddressForm all the fields will be shown.

@thesahindia

thesahindia commented Aug 3, 2022 •

Copy link
Copy Markdown
Member Author

I am seeing two bugs from a long time but not sure if they are reproducible in the actual flow (I am just rendering additional details page because, you have to be in the beta to access this page)
Looks like it's reproducible, just got logged here. Will post the other one on slack.

  1. We fetch the first name, last name from the profile and if you submit that you will get an error.
  2. At ios app the field gets cleared if you add only one alphabet/digit
Screen.Recording.2022-08-04.at.12.34.56.AM.mov

@rushatgabhane

rushatgabhane commented Aug 5, 2022 •

Copy link
Copy Markdown
Member

@thesahindia reported a bug - inputs are getting cleared automatically.

https://expensify.slack.com/archives/C01GTK53T8Q/p1659642916824439?thread_ts=1659585208.087999&cid=C01GTK53T8Q

@thesahindia would you like to solve this bug in this PR itself? Because I don't like the fact that we'll be shipping a unusable page. (ofc the bounty will be increased + reporting bonus)

@rushatgabhane

Copy link
Copy Markdown
Member

Please merge main into your branch as we've updated RN

@thesahindia

Copy link
Copy Markdown
Member Author

@thesahindia would you like to solve this bug in this PR itself? Because I don't like the fact that we'll be shipping a unusable page. (ofc the bounty will be increased + reporting bonus)

Hmm I tried but only found the solution for this one

@rushatgabhane

Copy link
Copy Markdown
Member

Hmm I tried but only found the solution for this one

that's alright

@rushatgabhane

Copy link
Copy Markdown
Member

@thesahindia is the search functionality working for you?

Screen.Recording.2022-08-10.at.12.25.15.AM.mov

@thesahindia

Copy link
Copy Markdown
Member Author

Yeah it's working, you have to check this at desktop. You won't be able to test this on local web

Screen.Recording.2022-08-10.at.12.41.08.AM.mov

@rushatgabhane

rushatgabhane commented Aug 9, 2022 •

Copy link
Copy Markdown
Member

Okayy, thanks for the info! I just confirmed it again.

@rushatgabhane rushatgabhane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonilBhavsar LGTM! 🎉

PR Reviewer Checklist
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • Any functional components have the displayName property
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn’t already exist
    • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

@MonilBhavsar

Copy link
Copy Markdown
Contributor

Could anyone please clarify testing steps. I'm not able to get additional details page during bank account setup. May be I'm missing something?

@thesahindia

Copy link
Copy Markdown
Member Author

Could anyone please clarify testing steps. I'm not able to get additional details page during bank account setup. May be I'm missing something?

I tested it by rendering this EnablePaymentsPage at a different route. But there are two ways to reach this page ( I found them on some other issues )

1st way (not really sure about this but you have to in some beta for this) -

  1. Click on Fab icon
  2. Send money
  3. Complete the Onfido verification

2nd -

  1. Go to Settings
  2. Go to Payments
  3. Click on Transfer Balance (you must have some balance available)

@thesahindia

thesahindia commented Aug 22, 2022 •

Copy link
Copy Markdown
Member Author

Found the QA steps (don't know if this works locally on web, probably it will work for desktop app)

  1. The account already has a bank account added.
  2. Hit green plus button
  3. Send money
  4. Enter amount
  5. Enter email
  6. Pay with Expensify

or just visit https://new.expensify.com/enable-payments

@rushatgabhane

Copy link
Copy Markdown
Member

cc @MonilBhavsar #10234 (comment)

@rushatgabhane

Copy link
Copy Markdown
Member

@MonilBhavsar bump :)

#10234 (comment)

@MonilBhavsar

Copy link
Copy Markdown
Contributor

Oops sorry, missed this. Looking now 👁️

@MonilBhavsar

Copy link
Copy Markdown
Contributor

@thesahindia since it's been a while. Could you please merge main in this branch. Thank you! 🙏

@thesahindia

Copy link
Copy Markdown
Member Author

I am out right now, away from my mac. It will take me a few hours (2 maybe)

@thesahindia

Copy link
Copy Markdown
Member Author

@thesahindia since it's been a while. Could you please merge main in this branch. Thank you! 🙏

Done :)

@MonilBhavsar

Copy link
Copy Markdown
Contributor

In some accounts where bank account is already setup, additional information form is only accessed by going to enable-payments in url. If you want to add that to tests/QA section

@thesahindia

Copy link
Copy Markdown
Member Author

In some accounts where bank account is already setup, additional information form is only accessed by going to enable-payments in url. If you want to add that to tests/QA section

Done, Added.

@MonilBhavsar

Copy link
Copy Markdown
Contributor

Thanks!

@MonilBhavsar
MonilBhavsar merged commit 3335b18 into Expensify:main Sep 19, 2022
@melvin-bot

melvin-bot Bot commented Sep 19, 2022

Copy link
Copy Markdown

@MonilBhavsar looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@MonilBhavsar

Copy link
Copy Markdown
Contributor

PR Reviewer and contributor checklist are completed. Looks like we're still working to fix the integration.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @MonilBhavsar in version: 1.2.2-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @luacmartins in version: 1.2.2-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants